Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdn): get item unit from buffer while deleting it #5831

Merged
merged 8 commits into from
Jun 3, 2021
Merged

fix(cdn): get item unit from buffer while deleting it #5831

merged 8 commits into from
Jun 3, 2021

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Jun 2, 2021

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 2, 2021

CDS Report build-all-cds#16088.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 2, 2021

CDS Report build-all-cds#16088.2 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 2, 2021

CDS Report build-all-cds#16088.3 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

fsamin
fsamin previously approved these changes Jun 2, 2021
View reviewed changes
yesnault
yesnault previously approved these changes Jun 3, 2021
View reviewed changes
@sguiheux sguiheux dismissed stale reviews from yesnault and fsamin via f6d3106 June 3, 2021 08:41
richardlt
richardlt previously approved these changes Jun 3, 2021
View reviewed changes
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 3, 2021

CDS Report build-all-cds#16093.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sguiheux sguiheux merged commit b8c656e into master Jun 3, 2021
@sguiheux sguiheux deleted the fixReadInBuffer branch June 18, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt